Add minimum span duration filtering by davidfowl · Pull Request #17299 · microsoft/aspire

davidfowl · 2026-05-20T04:00:54Z

Description

Adds minimum span duration filtering so performance profiling can hide very short spans that add noise to trace analysis.

Users can filter spans by duration in three places:

Dashboard Trace Detail: add a structured filter for Duration (ms) from the existing filter dialog. Numeric duration fields use numeric input and comparison operators (>=, >, <=, <) instead of string combobox operators.
Dashboard telemetry APIs: pass minDurationMs to span and trace endpoints.
Aspire CLI: pass --min-duration or --min-duration-ms to aspire telemetry spans and aspire telemetry traces.

Trace Detail behavior

The duration filter is intentionally a per-span profiling noise filter:

A matching span remains visible.
Ancestors of matching spans remain visible so the trace stays navigable.
Short descendants are not kept just because their parent matched the duration threshold.

This makes it useful for profiling large traces where a slow parent can contain many tiny implementation-detail spans that should be hidden.

Performance work

This PR also adds Dashboard BenchmarkDotNet coverage for span filtering and TelemetryRepository.GetTraces query/filter scenarios.

TelemetryRepository.GetTraces now scans traces once for filtering, paging, total count, and MaxDuration, while only cloning returned page items. Duration filters compare parsed numeric thresholds directly instead of formatting/parsing every span duration.

Benchmark result for the intended profiling miss case over 10k spans:

Scenario	Before	After
No-match duration filter	1,047.9 µs / 243 KB	66.5 µs / 623 B

Matching/no-filter queries are still dominated by cloning the returned page, so those scenarios are roughly unchanged.

User-facing usage

Dashboard Trace Detail:

Open a trace.
Open the filter dialog.
Choose Duration (ms).
Choose a numeric comparison such as >=.
Enter a duration in milliseconds, for example 50.

Dashboard telemetry API:

GET /api/telemetry/spans?minDurationMs=50
GET /api/telemetry/traces?minDurationMs=50
GET /api/telemetry/traces/{traceId}?minDurationMs=50

CLI:

aspire telemetry spans --dashboard-url http://localhost:15889 --api-key <key> --min-duration 50
aspire telemetry traces --trace-id <trace-id> --min-duration 50

Command help:

--min-duration, --min-duration-ms <min-duration>  Filter by minimum span duration in milliseconds

Validation

dotnet test --project tests/Aspire.Dashboard.Tests/Aspire.Dashboard.Tests.csproj --no-launch-profile -- --filter-class "*.TelemetryApiServiceTests" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"
dotnet test --project tests/Aspire.Dashboard.Tests/Aspire.Dashboard.Tests.csproj --no-launch-profile -- --filter-class "*.TelemetryApiServiceTests" --filter-class "*.DashboardUrlsTests" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"
dotnet test --project tests/Aspire.Dashboard.Tests/Aspire.Dashboard.Tests.csproj --no-launch-profile -- --filter-class "*.TraceTests" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"
dotnet test --project tests/Aspire.Cli.Tests/Aspire.Cli.Tests.csproj --no-launch-profile -- --filter-class "*.TelemetrySpansCommandTests" --filter-class "*.TelemetryTracesCommandTests" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"
dotnet test --project tests/Aspire.Dashboard.Components.Tests/Aspire.Dashboard.Components.Tests.csproj --no-launch-profile -- --filter-class "*.FilterDialogTests" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"
dotnet test --project tests/Aspire.Dashboard.Components.Tests/Aspire.Dashboard.Components.Tests.csproj --no-launch-profile -- --filter-class "*.TraceDetailsTests" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"
dotnet test --project tests/Aspire.Dashboard.Components.Tests/Aspire.Dashboard.Components.Tests.csproj --no-launch-profile -- --filter-class "*.SpanWaterfallViewModelTests" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"
dotnet build benchmarks/Aspire.Dashboard.Benchmarks/Aspire.Dashboard.Benchmarks.csproj -c Release --no-restore
dotnet run -c Release --project benchmarks/Aspire.Dashboard.Benchmarks/Aspire.Dashboard.Benchmarks.csproj --filter '*TelemetryRepositoryBenchmarks*' --join
dotnet run -c Release --project benchmarks/Aspire.Dashboard.Benchmarks/Aspire.Dashboard.Benchmarks.csproj --filter '*SpanFilteringBenchmarks*' --join
Standalone dashboard E2E with OTLP test spans, validating:
- otel spans --min-duration 50
- otel traces --trace-id <trace-id> --min-duration 50
- browser Trace Detail duration filter hides spans through the filter dialog
- imported synthetic OTLP dataset for profiling/noise filtering
dotnet build /t:UpdateXlf src/Aspire.Dashboard/Aspire.Dashboard.csproj
git diff --check

Checklist

Is this feature complete?
- Yes. Ready to ship.
- No. Follow-up changes expected.
Are you including unit tests for the changes and scenario tests if relevant?
- Yes
- No
Did you add public API?
- Yes
  - If yes, did you have an API Review for it?
    - Yes
    - No
  - Did you add <remarks /> and <code /> elements on your triple slash comments?
    - Yes
    - No
- No
Does the change make any security assumptions or guarantees?
- Yes
  - If yes, have you done a threat model and had a security review?
    - Yes
    - No
- No

Add dashboard trace-detail filtering for spans shorter than a configured duration, expose the same minDurationMs filter through telemetry APIs, and add CLI --min-duration support for spans and traces. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-05-20T04:01:53Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17299

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17299"

Copilot

Pull request overview

Adds a minimum span duration filter across the Dashboard telemetry APIs, Dashboard trace detail UI, and Aspire CLI telemetry commands so very short spans can be hidden to reduce trace noise.

Changes:

Adds minDurationMs query support to dashboard telemetry endpoints (spans, traces, trace detail) and applies filtering in TelemetryApiService.
Adds a “Minimum duration (ms)” filter control to the Trace Detail page and filters spans client-side in the grid.
Adds --min-duration/--min-duration-ms to CLI otel spans / otel traces, plus test coverage and localization resources.

Show a summary per file

File	Description
tests/Aspire.Dashboard.Tests/TelemetryApiServiceTests.cs	Adds unit tests for minimum-duration filtering behavior in telemetry APIs.
tests/Aspire.Dashboard.Tests/DashboardUrlsTests.cs	Verifies `minDurationMs` is appended to telemetry API URLs.
tests/Aspire.Dashboard.Components.Tests/Shared/FluentUISetupHelpers.cs	Updates Fluent UI JS interop test setup for text/number fields.
tests/Aspire.Dashboard.Components.Tests/Pages/TraceDetailsTests.cs	Adds component test for minimum-duration filtering in trace details grid.
tests/Aspire.Cli.Tests/Commands/TelemetryTracesCommandTests.cs	Tests CLI traces command includes `minDurationMs` in requests.
tests/Aspire.Cli.Tests/Commands/TelemetrySpansCommandTests.cs	Tests CLI spans command includes `minDurationMs` in requests.
src/Shared/DashboardUrls.cs	Adds optional `minDurationMs` query parameter to telemetry URL builders.
src/Aspire.Dashboard/DashboardEndpointsBuilder.cs	Wires `minDurationMs` from query string into telemetry API service calls.
src/Aspire.Dashboard/Api/TelemetryApiService.cs	Implements minimum-duration filtering for spans/traces/trace detail + follow streaming.
src/Aspire.Dashboard/Components/Pages/TraceDetail.razor	Adds minimum-duration input control (desktop + mobile toolbars).
src/Aspire.Dashboard/Components/Pages/TraceDetail.razor.cs	Applies minimum-duration filter when computing visible span view models.
src/Aspire.Dashboard/Components/Pages/TraceDetail.razor.css	Styles the new minimum-duration filter UI.
src/Aspire.Dashboard/Resources/TraceDetail.resx	Adds localized strings for the new UI label/placeholder/title.
src/Aspire.Dashboard/Resources/TraceDetail.Designer.cs	Generated accessors for new TraceDetail resource strings.
src/Aspire.Dashboard/Resources/xlf/TraceDetail.cs.xlf	Localization entries for new TraceDetail strings (cs).
src/Aspire.Dashboard/Resources/xlf/TraceDetail.de.xlf	Localization entries for new TraceDetail strings (de).
src/Aspire.Dashboard/Resources/xlf/TraceDetail.es.xlf	Localization entries for new TraceDetail strings (es).
src/Aspire.Dashboard/Resources/xlf/TraceDetail.fr.xlf	Localization entries for new TraceDetail strings (fr).
src/Aspire.Dashboard/Resources/xlf/TraceDetail.it.xlf	Localization entries for new TraceDetail strings (it).
src/Aspire.Dashboard/Resources/xlf/TraceDetail.ja.xlf	Localization entries for new TraceDetail strings (ja).
src/Aspire.Dashboard/Resources/xlf/TraceDetail.ko.xlf	Localization entries for new TraceDetail strings (ko).
src/Aspire.Dashboard/Resources/xlf/TraceDetail.pl.xlf	Localization entries for new TraceDetail strings (pl).
src/Aspire.Dashboard/Resources/xlf/TraceDetail.pt-BR.xlf	Localization entries for new TraceDetail strings (pt-BR).
src/Aspire.Dashboard/Resources/xlf/TraceDetail.ru.xlf	Localization entries for new TraceDetail strings (ru).
src/Aspire.Dashboard/Resources/xlf/TraceDetail.tr.xlf	Localization entries for new TraceDetail strings (tr).
src/Aspire.Dashboard/Resources/xlf/TraceDetail.zh-Hans.xlf	Localization entries for new TraceDetail strings (zh-Hans).
src/Aspire.Dashboard/Resources/xlf/TraceDetail.zh-Hant.xlf	Localization entries for new TraceDetail strings (zh-Hant).
src/Aspire.Cli/Commands/TelemetryCommandHelpers.cs	Introduces the shared `--min-duration/--min-duration-ms` option definition.
src/Aspire.Cli/Commands/TelemetrySpansCommand.cs	Passes minimum duration through to spans API URL.
src/Aspire.Cli/Commands/TelemetryTracesCommand.cs	Passes minimum duration through to traces/trace detail API URLs.
src/Aspire.Cli/Resources/TelemetryCommandStrings.resx	Adds description string for the new CLI option.
src/Aspire.Cli/Resources/TelemetryCommandStrings.Designer.cs	Generated accessor for the new CLI option description.
src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.cs.xlf	Localization entry for new CLI option description (cs).
src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.de.xlf	Localization entry for new CLI option description (de).
src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.es.xlf	Localization entry for new CLI option description (es).
src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.fr.xlf	Localization entry for new CLI option description (fr).
src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.it.xlf	Localization entry for new CLI option description (it).
src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.ja.xlf	Localization entry for new CLI option description (ja).
src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.ko.xlf	Localization entry for new CLI option description (ko).
src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.pl.xlf	Localization entry for new CLI option description (pl).
src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.pt-BR.xlf	Localization entry for new CLI option description (pt-BR).
src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.ru.xlf	Localization entry for new CLI option description (ru).
src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.tr.xlf	Localization entry for new CLI option description (tr).
src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.zh-Hans.xlf	Localization entry for new CLI option description (zh-Hans).
src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.zh-Hant.xlf	Localization entry for new CLI option description (zh-Hant).

Copilot's findings

Files not reviewed (2)

src/Aspire.Cli/Resources/TelemetryCommandStrings.Designer.cs: Language not supported
src/Aspire.Dashboard/Resources/TraceDetail.Designer.cs: Language not supported

Comments suppressed due to low confidence (2)

src/Aspire.Cli/Commands/TelemetrySpansCommand.cs:101

--min-duration accepts negative/NaN/Infinity values and they’ll be silently treated as “no duration filter” by the dashboard API (since minDurationMs <= 0 or non-finite becomes null). This makes the CLI option misleading. Add validation similar to --limit (e.g., require a finite value >= 0, or reject < 0/non-finite with an InvalidCommand exit and a clear error message).

        var traceId = parseResult.GetValue(s_traceIdOption);
        var hasError = parseResult.GetValue(s_hasErrorOption);
        var dashboardUrl = parseResult.GetValue(s_dashboardUrlOption);
        var apiKey = parseResult.GetValue(s_apiKeyOption);
        var search = parseResult.GetValue(s_searchOption);
        var minimumDuration = parseResult.GetValue(s_minimumDurationOption);

        // Validate --limit value
        if (limit.HasValue && limit.Value < 1)
        {
            return CommandResult.Failure(CliExitCodes.InvalidCommand, TelemetryCommandStrings.LimitMustBePositive);
        }

src/Aspire.Cli/Commands/TelemetryTracesCommand.cs:99

--min-duration accepts negative/NaN/Infinity values and they’ll be silently treated as “no duration filter” by the dashboard API (minDurationMs <= 0 or non-finite becomes null). This makes the CLI option misleading. Add validation similar to --limit (e.g., require a finite value >= 0, or reject < 0/non-finite with an InvalidCommand exit and a clear error message).

        var format = parseResult.GetValue(s_formatOption);
        var limit = parseResult.GetValue(s_limitOption);
        var traceId = parseResult.GetValue(s_traceIdOption);
        var hasError = parseResult.GetValue(s_hasErrorOption);
        var dashboardUrl = parseResult.GetValue(s_dashboardUrlOption);
        var apiKey = parseResult.GetValue(s_apiKeyOption);
        var search = parseResult.GetValue(s_searchOption);
        var minimumDuration = parseResult.GetValue(s_minimumDurationOption);

        // Validate --limit value
        if (limit.HasValue && limit.Value < 1)
        {
            return CommandResult.Failure(CliExitCodes.InvalidCommand, TelemetryCommandStrings.LimitMustBePositive);
        }

Files reviewed: 43/45 changed files
Comments generated: 2

# Conflicts: # src/Aspire.Dashboard/Components/Pages/TraceDetail.razor # src/Aspire.Dashboard/Components/Pages/TraceDetail.razor.css

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

JamesNK

1 issue found (performance).

JamesNK · 2026-05-20T13:49:02Z

no

How about, "Min duration" as the label. The value is a dropdown. Dropdown values are (none), 50ms, 100ms, 500ms, 1s, 5s, 10s. I think that's a good balance between options while providing a clean/easy to use UI.

I worry about what else we add in the future (i.e. a max duration) and putting UI in the horizontal menu won't scale. Duration should really be a filter option, and then the operator would be greater than, less than. Then you enter a value and it appears with other filters.

davidfowl · 2026-05-20T14:02:42Z

Fixed values don’t cut it (though we can be smart about calculating a scale). I think it needs to be possible to enter a value.

I am too worried about horizontal space as it doesn’t scale well for general filters

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

davidfowl · 2026-05-20T15:02:18Z

Acknowledged. I addressed the performance issue from the inline thread and pushed the fix.

IEvangelist · 2026-05-20T19:57:45Z

PR Testing Report

PR Information

PR: Add minimum span duration filtering #17299 - Add minimum span duration filtering
Head commit: e0f50ee9dd2e1a4c627f0a1c21909f9406491f03
Tester: GitHub Copilot CLI on Windows

CLI Version Verification

Expected commit: e0f50ee9dd2e1a4c627f0a1c21909f9406491f03
Installed CLI: 13.4.0-pr.17299.ge0f50ee9
Status: Passed - the dogfood CLI matched the PR head commit suffix.

Changes Analyzed

The PR adds minimum span duration filtering to CLI telemetry commands and dashboard trace-detail views/APIs, including:

aspire otel spans --min-duration / --min-duration-ms
aspire otel traces --min-duration / --min-duration-ms
dashboard telemetry API minDurationMs query support
trace-detail UI filtering and localized resource strings

Test Scenarios Executed

Scenario 1: Dogfood CLI install and option discovery

Objective: Verify the PR dogfood artifact is available, matches the PR head, and exposes the new CLI options.

Result: Passed

Evidence:

Installed from workflow run: https://github.com/microsoft/aspire/actions/runs/26171097209
aspire --version output: 13.4.0-pr.17299.ge0f50ee9
aspire otel spans --help lists --min-duration, --min-duration-ms <min-duration>.
aspire otel traces --help lists --min-duration, --min-duration-ms <min-duration>.

Scenario 2: Fresh starter app restore/build with PR packages

Objective: Verify a new Aspire starter app can be created and built using the PR package channel.

Steps:

Ran aspire new aspire-starter --name SpanFilterSmoke --output . --non-interactive.
Ran dotnet build .\SpanFilterSmoke.AppHost\SpanFilterSmoke.AppHost.csproj --nologo.

Result: Passed

Evidence:

Template version selected: 13.4.0-pr.17299.ge0f50ee9
Build result: Build succeeded. with 0 warnings and 0 errors.

Scenario 3: CLI duration filter query propagation with mock dashboard API

Objective: Verify the PR CLI sends the expected minDurationMs query parameter for spans, trace list, and trace detail requests.

Steps:

Started a local mock dashboard telemetry API.
Ran aspire otel spans --dashboard-url <mock> --format json --limit 5 --min-duration 50.5 --non-interactive --nologo.
Ran aspire otel traces --dashboard-url <mock> --format json --limit 5 --min-duration-ms 75.25 --non-interactive --nologo.
Ran aspire otel traces --dashboard-url <mock> --trace-id abc1234567890def --format json --min-duration 25 --non-interactive --nologo.

Result: Passed

Captured requests:
ext GET /api/telemetry/spans?limit=5&minDurationMs=50.5 GET /api/telemetry/traces?limit=5&minDurationMs=75.25 GET /api/telemetry/traces/abc1234567890def?minDurationMs=25

Scenario 4: Live AppHost telemetry filtering

Objective: Exercise the filter against a running starter AppHost and dashboard.

Result: Inconclusive

Observation: A starter AppHost launched successfully, but the live telemetry run was not reliable in this agent environment: one attempt produced empty telemetry arrays, and a later follow-up could not reconnect to the dashboard after startup. I did not count this as a PR failure because the controlled dashboard API scenario verified the CLI request behavior added by this PR.

Summary

Scenario	Status	Notes
Dogfood CLI install/version and option discovery	Passed	Artifact version matched PR head and help showed both new option names.
Fresh starter app restore/build	Passed	Generated AppHost built successfully with PR packages.
CLI duration filter query propagation	Passed	`minDurationMs` was sent for spans, trace list, and trace detail requests.
Live AppHost telemetry filtering	Inconclusive	Dashboard telemetry was not reliable enough in this agent run to use as pass/fail evidence.

Overall Result

Passed for the validated CLI/package scenarios. I did not find a PR-specific failure in the executed coverage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-05-21T04:55:38Z

Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
GitHub was asked to rerun all failed jobs for that attempt, and the rerun is being tracked in the rerun attempt.
The job links below point to the failed attempt jobs that matched the retry-safe transient failure rules.

Tests / Hosting-1 / Hosting-1 (windows-latest) - Job-level runner or infrastructure failure matched the transient allowlist.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

JamesNK · 2026-05-22T03:31:41Z

The condition is lost when switching back and forth between a numeric and string field.

It should reset to the default.

JamesNK · 2026-05-22T03:59:33Z

Traces should support duration filter. It would work on the duration of the entire trace. But that can happen in a future PR.

davidfowl · 2026-05-22T04:13:56Z

Traces should support duration filter. It would work on the duration of the entire trace. But that can happen in a future PR.

@JamesNK file that issue plz.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Treat trace duration filters as per-span noise filters so a long root span no longer brings every short child back into view. Keep ancestors of matching spans visible for waterfall navigation and add regression coverage for the long-root/short-child case. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-05-22T07:21:09Z

Re-running the failed jobs in the CI workflow for this pull request because 3 jobs were identified as retry-safe transient failures in the CI run attempt.
GitHub was asked to rerun all failed jobs for that attempt, and the rerun is being tracked in the rerun attempt.
The job links below point to the failed attempt jobs that matched the retry-safe transient failure rules.

Tests / Hosting-1 / Hosting-1 (windows-latest) - Job-level runner or infrastructure failure matched the transient allowlist.
Tests / Hosting-5 / Hosting-5 (windows-latest) - Job-level runner or infrastructure failure matched the transient allowlist.
Tests / Cli.EndToEnd-KubernetesDeployWithPostgresTests / Cli.EndToEnd-KubernetesDeployWithPostgresTests (ubuntu-latest) - Test execution failure will be retried because 1 failed test(s) matched transient test failure patterns (Unable to access container registry during publish).

Matched test failure patterns (1 test)

Aspire.Cli.EndToEnd.Tests.KubernetesDeployWithPostgresTests.DeployK8sWithPostgres — Unable to access container registry during publish

Add BenchmarkDotNet coverage for dashboard trace filtering and optimize the Trace Detail filter path by avoiding recursive subtree scans, building parent maps in one pass, materializing grid data once, and comparing duration thresholds numerically. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add BenchmarkDotNet scenarios for TelemetryRepository trace ingestion and query filtering over 10k spans, including duration and no-match filters. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Cover dynamic filters combined with duration filtering, paging, total count, and max duration before optimizing TelemetryRepository.GetTraces. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Scan traces once when filtering, counting, paging, and computing max duration. Precompile common field filters so duration comparisons avoid per-span string formatting and parsing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-05-22T14:31:01Z

❓ CLI E2E Tests unknown — 95 passed, 0 failed, 5 unknown (commit 2609f46)

View all recordings

Status	Test	Recording
✅	AddPackageInteractiveWhileAppHostRunningDetached	✅ ▶️ View recording
✅	AddPackageWhileAppHostRunningDetached	✅ ▶️ View recording
✅	AgentCommands_AllHelpOutputs_AreCorrect	✅ ▶️ View recording
✅	AgentInitCommand_DefaultSelection_InstallsDefaultSkills	✅ ▶️ View recording
✅	AgentInitCommand_MigratesDeprecatedConfig	✅ ▶️ View recording
❔	AgentMcpListStructuredLogsFromStarterAppCore	❔ ▶️ View recording
✅	AllPublishMethodsBuildDockerImages	✅ ▶️ View recording
✅	AspireAddPackageVersionToDirectoryPackagesProps	✅ ▶️ View recording
✅	AspireInitSingleFileAppHostRunsViaDotnetRunAppHost	✅ ▶️ View recording
✅	AspireInitWithExistingAppHostDirRecreatesMissingNuGetConfigAndPreservesFiles	✅ ▶️ View recording
❔	AspireInitWithSolutionFileGeneratesAppHostThatBuildsAgainstChannelHive	❔ ▶️ View recording
✅	AspireUpdateRemovesAppHostPackageVersionFromDirectoryPackagesProps	✅ ▶️ View recording
✅	AspireUpdateRemovesOrphanAppHostPackageVersionWhenSdkAlreadyCurrent	✅ ▶️ View recording
✅	Banner_DisplayedOnFirstRun	✅ ▶️ View recording
✅	Banner_DisplayedWithExplicitFlag	✅ ▶️ View recording
✅	Banner_NotDisplayedWithNoLogoFlag	✅ ▶️ View recording
✅	CertificatesClean_RemovesCertificates	✅ ▶️ View recording
✅	CertificatesTrust_WithNoCert_CreatesAndTrustsCertificate	✅ ▶️ View recording
✅	CertificatesTrust_WithUntrustedCert_TrustsCertificate	✅ ▶️ View recording
✅	ConfigSetGet_CreatesNestedJsonFormat	✅ ▶️ View recording
✅	CreateAndRunAspireStarterProject	✅ ▶️ View recording
✅	CreateAndRunAspireStarterProjectWithBundle	✅ ▶️ View recording
✅	CreateAndRunEmptyAppHostProject	✅ ▶️ View recording
✅	CreateAndRunJavaEmptyAppHostProject	✅ ▶️ View recording
✅	CreateAndRunJsReactProject	✅ ▶️ View recording
✅	CreateAndRunPythonReactProject	✅ ▶️ View recording
✅	CreateAndRunTypeScriptEmptyAppHostProject	✅ ▶️ View recording
✅	CreateAndRunTypeScriptStarterProject	✅ ▶️ View recording
✅	CreateJavaAppHostWithViteApp	✅ ▶️ View recording
✅	CreateTypeScriptAppHostWithViteApp_UsesConfiguredToolchain	✅ ▶️ View recording
❔	DashboardRunWithAgentMcpCore	❔ ▶️ View recording
❔	DashboardRunWithOtelTracesReturnsNoTracesCore	❔ ▶️ View recording
✅	DeployK8sBasicApiService	✅ ▶️ View recording
✅	DeployK8sWithExternalHelmChart	✅ ▶️ View recording
✅	DeployK8sWithGarnet	✅ ▶️ View recording
✅	DeployK8sWithMongoDB	✅ ▶️ View recording
✅	DeployK8sWithMySql	✅ ▶️ View recording
✅	DeployK8sWithPostgres	✅ ▶️ View recording
✅	DeployK8sWithRabbitMQ	✅ ▶️ View recording
✅	DeployK8sWithRedis	✅ ▶️ View recording
✅	DeployK8sWithSqlServer	✅ ▶️ View recording
✅	DeployK8sWithValkey	✅ ▶️ View recording
✅	DeployTypeScriptAppToKubernetes	✅ ▶️ View recording
✅	DescribeCommandResolvesReplicaNames	✅ ▶️ View recording
✅	DescribeCommandShowsRunningResources	✅ ▶️ View recording
✅	DetachFormatJsonProducesValidJson	✅ ▶️ View recording
✅	DetachFormatJsonProducesValidJsonWhenRestartingExistingInstance	✅ ▶️ View recording
✅	DoListStepsShowsPipelineSteps	✅ ▶️ View recording
✅	DocsCommand_RendersInteractiveMarkdownFromLocalSource	✅ ▶️ View recording
✅	DoctorCommand_DetectsDeprecatedAgentConfig	✅ ▶️ View recording
✅	DoctorCommand_TypeScriptAppHostReportsMissingConfiguredToolchain	✅ ▶️ View recording
✅	DoctorCommand_WithSslCertDir_ShowsTrusted	✅ ▶️ View recording
✅	DoctorCommand_WithoutSslCertDir_ShowsPartiallyTrusted	✅ ▶️ View recording
✅	GeneratedAspireDevScript_StartsWatchMode_WithConfiguredToolchain	✅ ▶️ View recording
✅	GlobalMigration_HandlesCommentsAndTrailingCommas	✅ ▶️ View recording
✅	GlobalMigration_HandlesMalformedLegacyJson	✅ ▶️ View recording
✅	GlobalMigration_PreservesAllValueTypes	✅ ▶️ View recording
✅	GlobalMigration_SkipsWhenNewConfigExists	✅ ▶️ View recording
✅	GlobalSettings_MigratedFromLegacyFormat	✅ ▶️ View recording
✅	InitTypeScriptAppHost_AugmentsExistingViteRepoAtRoot	✅ ▶️ View recording
✅	InteractiveCSharpInitCreatesExpectedFiles	✅ ▶️ View recording
✅	InvalidAppHostPathWithComments_IsHealedOnRun	✅ ▶️ View recording
✅	JavaScriptHostingApisRunFromTypeScriptAppHost	✅ ▶️ View recording
✅	LatestCliCanStartStableChannelAppHost	✅ ▶️ View recording
✅	LatestCliCanStartStableChannelTypeScriptAppHost	✅ ▶️ View recording
✅	LegacySettingsMigration_AdjustsRelativeAppHostPath	✅ ▶️ View recording
✅	LogLevelTrace_ProducesTraceEntriesInCliLogFile	✅ ▶️ View recording
✅	LogsCommandShowsResourceLogs	✅ ▶️ View recording
✅	OtelLogsReturnsStructuredLogsFromStarterApp	✅ ▶️ View recording
✅	OtelLogsReturnsStructuredLogsFromStarterAppIsolated	✅ ▶️ View recording
✅	PsCommandListsRunningAppHost	✅ ▶️ View recording
✅	PsFormatJsonOutputsOnlyJsonToStdout	✅ ▶️ View recording
✅	PublishJavaScriptPatternsGeneratesExpectedDockerComposeArtifacts	✅ ▶️ View recording
✅	PublishWithConfigureEnvFileUpdatesEnvOutput	✅ ▶️ View recording
✅	PublishWithDockerComposeServiceCallbackSucceeds	✅ ▶️ View recording
✅	PublishWithoutOutputPathUsesAppHostDirectoryDefault	✅ ▶️ View recording
✅	ResourceCommand_FailedExecution_DisplaysAppHostLogPathAndLogContainsEntries	✅ ▶️ View recording
✅	ResourceCommand_FailsWhenInteractionServiceIsRequired	✅ ▶️ View recording
✅	ResourceCommand_SetAndDeleteParameterUpdatesDescribeOutput	✅ ▶️ View recording
✅	RestoreGeneratesSdkFiles	✅ ▶️ View recording
✅	RestoreGeneratesSdkFiles_WithConfiguredToolchain	✅ ▶️ View recording
✅	RestoreRefreshesGeneratedSdkAfterAddingIntegration	✅ ▶️ View recording
✅	RestoreSupportsConfigOnlyHelperPackageAndCrossPackageTypes	✅ ▶️ View recording
✅	RunFromParentDirectory_UsesExistingConfigNearAppHost	✅ ▶️ View recording
❔	RunPublishFailureScenarioAsync	❔ ▶️ View recording
✅	RunReportsSyntaxErrorsForDotNetAppHost	✅ ▶️ View recording
✅	RunReportsSyntaxErrorsForTypeScriptAppHost	✅ ▶️ View recording
✅	SecretCrudOnDotNetAppHost	✅ ▶️ View recording
✅	SecretCrudOnTypeScriptAppHost	✅ ▶️ View recording
✅	StagingChannel_ConfigureAndVerifySettings_ThenSwitchChannels	✅ ▶️ View recording
✅	StartAndWaitForTypeScriptSqlServerAppHostWithNativeAssets	✅ ▶️ View recording
✅	StartReportsSyntaxErrorsForDotNetAppHost	✅ ▶️ View recording
✅	StartReportsSyntaxErrorsForTypeScriptAppHost	✅ ▶️ View recording
✅	StopAllAppHostsFromAppHostDirectory	✅ ▶️ View recording
✅	StopJavaPolyglotAppHostUsingApphostDirectory	✅ ▶️ View recording
✅	StopNonInteractiveSingleAppHost	✅ ▶️ View recording
✅	StopTypeScriptPolyglotAppHostUsingApphostDirectory	✅ ▶️ View recording
✅	StopWithNoRunningAppHostExitsSuccessfully	✅ ▶️ View recording
✅	UnAwaitedChainsCompileWithAutoResolvePromises	✅ ▶️ View recording
✅	UpdateProjectChannelToStable_TypeScript_PicksUpStablePackages	✅ ▶️ View recording

_{📹 Recordings uploaded automatically from CI run #26275480593}

Copilot AI review requested due to automatic review settings May 20, 2026 04:00

davidfowl requested review from JamesNK, adamint and mitchdenny as code owners May 20, 2026 04:00

Copilot started reviewing on behalf of davidfowl May 20, 2026 04:01 View session

Copilot AI reviewed May 20, 2026

View reviewed changes

Comment thread src/Aspire.Dashboard/Api/TelemetryApiService.cs

Comment thread src/Aspire.Dashboard/Api/TelemetryApiService.cs

davidfowl and others added 2 commits May 19, 2026 21:11

Merge remote-tracking branch 'origin/main' into davidfowl/span-filtering

588cf1d

# Conflicts: # src/Aspire.Dashboard/Components/Pages/TraceDetail.razor # src/Aspire.Dashboard/Components/Pages/TraceDetail.razor.css

Fix telemetry trace ID filtering

0b753f4

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>